[PATCH] D122930: [Propeller] Promote functions with propeller profiles to .text.hot.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Analysis/BasicBlockSectionsProfileReader.h:30
+
+using llvm::SmallSet;
+using llvm::SmallVector;
----------------
Delete these `using llvm::*;`


================
Comment at: llvm/include/llvm/Analysis/BasicBlockSectionsProfileReader.h:38
+
+// This struct represents the cluster information for a machine basic block.
+struct BBClusterInfo {
----------------



================
Comment at: llvm/include/llvm/Analysis/BasicBlockSectionsProfileReader.h:48
+
+using ProgramBBClusterInfoMapTy = StringMap<SmallVector<BBClusterInfo, 4>>;
+
----------------
Check whether you want to use `SmallVector<BBClusterInfo, 0>` to make the element size smaller.


================
Comment at: llvm/lib/Analysis/BasicBlockSectionsProfileReader.cpp:1
+//===-- BasicBlockSectionsProfileReader.cpp
+//---=========----------------------------===//
----------------
Not sure the Reader should be placed in lib/Analysis. There is no precedent.


================
Comment at: llvm/lib/Analysis/BasicBlockSectionsProfileReader.cpp:26
+using llvm::SmallSet;
+using llvm::SmallVector;
+using llvm::StringMap;
----------------
delete


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122930/new/

https://reviews.llvm.org/D122930