[PATCH] D125036: [RISCV] Alignment relaxation
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 14 17:19:24 PDT 2022
MaskRay added inline comments.
================
Comment at: lld/ELF/Arch/RISCV.cpp:508
+
+// NOTE(gkm): The code structure is more complex than necessary
+// for handling R_RISCV_ALIGN alone. It is designed to accommodate
----------------
A NOTE does not need a username.
================
Comment at: lld/ELF/InputSection.h:154
+ mutable bool copiedData = false;
+ mutable ArrayRef<uint8_t> rawData;
----------------
reames wrote:
> Having variables defined between functions looks odd to my eye, but I see this already exists in the class. Maybe do a pre-nfc to group all the data together, and then add your new ones there?
The mutable can be avoided.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125036/new/
https://reviews.llvm.org/D125036
More information about the llvm-commits
mailing list