[PATCH] D125544: [lld][ELF] Support linking 'elf32-avr' with linker scripts

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 17:12:44 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/test/ELF/linkerscript/avr5-relocs.test:11
+OUTPUT_FORMAT("elf32-avr", "elf32-avr", "elf32-avr")
+OUTPUT_ARCH(avr:5)
+
----------------



================
Comment at: lld/test/ELF/linkerscript/avr5-sections.test:1
+# REQUIRES: avr
+
----------------
The tests should be merged into one.

Add a file-level comment explaining the purpose.

Use split-file to avoid `Inputs/*` files.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125544/new/

https://reviews.llvm.org/D125544



More information about the llvm-commits mailing list