[PATCH] D125600: [VP] Pass fast math flags to VP SDNodes.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I would split this patch. One for vp.fcmp and one for the other operations. The LLParser issue is concerning and may delay the vp.fcmp support. That shouldn't block the other nodes.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7604
     if (I == EVLParamPos)
       Op = DAG.getNode(ISD::ZERO_EXTEND, DL, EVLParamVT, Op);
     OpValues.push_back(Op);
----------------
If we hit this line on an FP operation with fast math flags, would we add fast math flags to an ISD::ZERO_EXTEND?

Might be safer to pass the flags to the DAG.getNode call in the default case.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fast-math-flags-vp.ll:3
+
+; Note: If the declartion moved after its use, there is still an error:
+; 'fast-math-flags specified for call without floating-point scalar or vector return type'.
----------------
declartion -> declaration


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125600/new/

https://reviews.llvm.org/D125600