[PATCH] D125612: [AMDGPU] Fix typo in cttz_zero_undef(x) -> cttz(x) fold test

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 14 11:25:26 PDT 2022


RKSimon created this revision.
RKSimon added reviewers: foad, arsenm.
Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
RKSimon requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

It looks like v_cttz_zero_undef_i64_with_select should be selecting '64' for the x != 0 case instead of '32' like we just did in the previous 'v_cttz_zero_undef_i32_with_select' test.

I THINK this is a copy+paste typo, but it might have been done on purpose - in which case we probably need a second vesion of the test with the correct value and a better test name.

Noticed by accident because it was causing some weird regressions....


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125612

Files:
  llvm/test/CodeGen/AMDGPU/cttz_zero_undef.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125612.429469.patch
Type: text/x-patch
Size: 6910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220514/8142a90c/attachment.bin>


More information about the llvm-commits mailing list