[PATCH] D125439: Ensure that the MRI CREATE/CREATETHIN commands overwrite the output file appropriately

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

LGTM.

> https://sourceware.org/binutils/docs/binutils/ar-scripts.html.

It may be useful to leave a space before the period as many applications may consider `.` part of the URI.



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1138
+    performOperation(ReplaceOrInsert, /*OldArchive=*/nullptr,
+                     /*OldArchiveBu=f*/ nullptr, &NewMembers);
   exit(0);
----------------
bd1976llvm wrote:
> jhenderson wrote:
> > This line is apparently cursed to have typos in it :-D
> :)
clang-format will delete the space between `/*OldArchiveBuf=*/ nullptr` but it may not be necessary to modify the line now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125439/new/

https://reviews.llvm.org/D125439