[PATCH] D125556: [APInt] Allow extending and truncating to the same width

Fri May 13 14:26:31 PDT 2022

craig.topper added a comment.

In D125556#3512512 <https://reviews.llvm.org/D125556#3512512>, @foad wrote:

> @craig.topper sorry to reply to a comment that you deleted, but I did want to address this here:
>
>> Oh I see those [OrSelf] functions allow the BitWidth to not be equal. That feels like an unintentional hole.
>
> Yes, I suspect it was unintentional, but I can't prove it, and some uses of that unintentional behaviour had crept into the tree. So my plan was:
>
> 1. Document the behaviour, as a basis for discussing the following steps: fcbf617dcc517291785dbf2d457af5a5f1e60cca <https://reviews.llvm.org/rGfcbf617dcc517291785dbf2d457af5a5f1e60cca>
> 2. Change the in-tree users to do something different: D125557 <https://reviews.llvm.org/D125557>
> 3. Deprecate the methods to give out-of-tree users a chance to catch up: D125558 <https://reviews.llvm.org/D125558>
> 4. Remove the methods: D125559 <https://reviews.llvm.org/D125559>

I saw the patch stack after I posted so I assume it had been addressed, but thanks for clarifying.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125556/new/

https://reviews.llvm.org/D125556