[PATCH] D125582: [llvm-ml] Add support for extern proc

[Eric Astor via Phabricator via llvm-commits]

epastor added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6040
+      KnownType[Name.lower()] = Type;
+    else if (!TypeName.equals_insensitive("proc"))
       return Error(TypeLoc, "unrecognized type");
----------------
Can we check this before doing the lookup? It seems odd to do the complicated check first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125582/new/

https://reviews.llvm.org/D125582