[PATCH] D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Mostly looks good to me.



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-bbaddrmap-disassemble-symbolize-operands-multi-section.yaml:1
+## Test for --symbolize-operands with SHT_LLVM_BB_ADDR_MAP sections present
+## in the object file. This tests the case involving multiple text sections.
----------------
Can the test be merged into the other one?


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-bbaddrmap-disassemble-symbolize-operands.yaml:1
+## Test for --symbolize-operands with a SHT_LLVM_BB_ADDR_MAP section present in
+## the object file.
----------------
Consider using wording like:
`## Test that in the presence of SHT_LLVM_BB_ADDR_MAP, --symbolize-operands can display <BB.*> labels.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560