[PATCH] D125558: [APInt] Deprecate truncOrSelf, zextOrSelf and sextOrSelf

Fri May 13 12:20:10 PDT 2022

foad added a comment.

In D125558#3512236 <https://reviews.llvm.org/D125558#3512236>, @lattner wrote:

> This is great in concept but I think we have macros to deprecate things in compiler.h,

The first version of this patch used LLVM_ATTRIBUTE_DEPRECATED but that was removed recently in favour of the standard `[[deprecated]]`: D94219 <https://reviews.llvm.org/D94219>, 903c30f4d1f3bc0d1aae9ca83af17c0062d02b40 <https://reviews.llvm.org/rG903c30f4d1f3bc0d1aae9ca83af17c0062d02b40>

> please also make sure all in tree uses are removed before landing this.

Should be done in D125557 <https://reviews.llvm.org/D125557>.

> Are there any APInt docs or comments that need to be updated?

I don't think so, at least I couldn't find any other mentions of the `truncOrSelf` etc names in the whole monorepo.

> Are you keeping APSInt in sync as well?

APSInt never had these methods, so I don't think there's anything to do there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125558/new/

https://reviews.llvm.org/D125558