[PATCH] D125567: [AMDGPU] Shrink MAD/FMA to MADAK/MADMK/FMAAK/FMAMK on GFX10

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:348
+      Swap = true;
+    } else if (Src0.isReg() && TRI->isVGPR(*MRI, Src0.getReg())) {
+    } else {
----------------
A leftover?


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:355
+    default:
+      llvm_unreachable("");
+    case AMDGPU::V_MAD_F32_e64:
----------------
Add some text here.


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:369
+      Swap = true;
+    } else if (Src1.isImm() && !TII->isInlineConstant(Src1)) {
+    } else {
----------------
Same here...


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:376
+    default:
+      llvm_unreachable("");
+    case AMDGPU::V_MAD_F32_e64:
----------------
Same here...


================
Comment at: llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp:399
+  } else {
+    TII->removeModOperands(MI);
+    MI.setDesc(TII->get(NewOpcode));
----------------
You bail if hasAnyModifiersSet().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125567/new/

https://reviews.llvm.org/D125567