[PATCH] D125498: [AMDGPU] gfx11 scalar alu instructions

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 10:37:00 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6394
+    Value = StringSwitch<int>(ValueName)
+                .Case("SAME", 0)
+                .Case("NEXT", 1)
----------------
Joe_Nash wrote:
> rampitec wrote:
> > All these magic numbers shall go into SIDefines.h.
> Good idea for a refactor, can we do this in a later patch?
Sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125498/new/

https://reviews.llvm.org/D125498



More information about the llvm-commits mailing list