[PATCH] D125569: [AMDGPU] Mark sendmsg hasSideEffects. NFC
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 13 10:32:50 PDT 2022
Joe_Nash created this revision.
Joe_Nash added a reviewer: foad.
Herald added subscribers: kosarev, hsmhsm, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.
Address the FIXME by marking the sendmsg instructions with
hasSideEffects.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D125569
Files:
llvm/lib/Target/AMDGPU/SOPInstructions.td
Index: llvm/lib/Target/AMDGPU/SOPInstructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/SOPInstructions.td
+++ llvm/lib/Target/AMDGPU/SOPInstructions.td
@@ -1284,12 +1284,15 @@
}
let Uses = [EXEC, M0] in {
-// FIXME: Should this be mayLoad+mayStore?
def S_SENDMSG : SOPP_Pseudo <"s_sendmsg" , (ins SendMsgImm:$simm16), "$simm16",
- [(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]>;
+ [(int_amdgcn_s_sendmsg (i32 timm:$simm16), M0)]> {
+ let hasSideEffects = 1;
+}
def S_SENDMSGHALT : SOPP_Pseudo <"s_sendmsghalt" , (ins SendMsgImm:$simm16), "$simm16",
- [(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]>;
+ [(int_amdgcn_s_sendmsghalt (i32 timm:$simm16), M0)]> {
+ let hasSideEffects = 1;
+}
} // End Uses = [EXEC, M0]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125569.429290.patch
Type: text/x-patch
Size: 796 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220513/832cd4e5/attachment.bin>
More information about the llvm-commits
mailing list