[PATCH] D125319: [AMDGPU] gfx11 BUF Instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 08:15:41 PDT 2022


Joe_Nash added a comment.

In D125319#3508748 <https://reviews.llvm.org/D125319#3508748>, @dp wrote:

> Overall looks fine.
>
> A couple of questions:
>
> - Is dlc a legal modifier for buffer_atomic_* instructions?
> - Why there are no tests for buffer_atomic_* with dlc? There should be at least one negative test with dlc if it is not legal.

FYI, it is legal. I am discussing with @Petar.Avramovic how to support it and I will either update this patch or submit a follow up one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125319/new/

https://reviews.llvm.org/D125319



More information about the llvm-commits mailing list