[PATCH] D125183: Add opaque pointers to the llvm-c API

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 07:51:50 PDT 2022


nikic added inline comments.


================
Comment at: llvm/tools/llvm-c-test/main.c:52
   fprintf(stderr, "    Read bitcode file from stdin - print it back out\n\n");
+  fprintf(stderr, "  * --echo -opaque-pointers\n");
+  fprintf(stderr, "    Read bitcode file from stdin - print it back out in "
----------------
nico-abram wrote:
> nikic wrote:
> > Make it `--echo --opaque-pointers` for the sake of consistency?
> I used `-opaque-pointers` since that's what the tools use, like `llvm-as` and `llvm-dis`, as documented [here](https://llvm.org/docs/OpaquePointers.html#opaque-pointers-mode)
> 
> If keeping it consistent with the rest of llvm-c-test is more important I can change it
The preferred option format is tool-specific -- `opt` etc do accept options in `--opaque-pointers` format as well, but for historical reason we tend to use the single-dash spelling for them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125183/new/

https://reviews.llvm.org/D125183



More information about the llvm-commits mailing list