[PATCH] D125204: [RISCV] Use RISCVISAInfo to parse arch string from ELF build attribute.

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng marked an inline comment as done.
kito-cheng added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:329-330
+    std::vector<std::string> FeatureVector = ISAInfo->toFeatureVector();
+    for (const std::string &Feature : FeatureVector)
+      Features.AddFeature(StringRef(Feature));
   }
----------------
jhenderson wrote:
> This is what I meant.
I thought range based for should match the type of the source container, it's my first time to know this usage, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125204/new/

https://reviews.llvm.org/D125204