[PATCH] D125516: [GlobalISel] Handle constant splat in funnel shift combine

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM. Maybe wait a day in case anyone else has opinions about the names you used for the new matchers.



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:121
+
+    } else if (auto MaybeCstSplat = matchConstantSplat<ConstT>(Reg, MRI)) {
+      CR = *MaybeCstSplat;
----------------
No else after return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125516/new/

https://reviews.llvm.org/D125516