[PATCH] D125516: [GlobalISel] Handle constant splat in funnel shift combine

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

Looks reasonable to me.



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fsh.mir:135
+---
+name: fsh_v2i32_const
+tracksRegLiveness: true
----------------
Precommit this?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/combine-rot.mir:125
+---
+name: rot_v2i32_const
+tracksRegLiveness: true
----------------
Precommit this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125516/new/

https://reviews.llvm.org/D125516