[PATCH] D125427: [TableGen] Add a new json textmate description for syntax highlighting

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 13 00:21:14 PDT 2022


rriddle added a comment.

Yeah, I'm not sure who would be good to review the actual json itself. Mostly just wondering if I should care about the existing xml package or not, happy to land this and not care about the other thing.

Here are some vscode screen grabs comparing this (in the MLIR extension) with the "LLVM TableGen" extension (which is what I think most people use for vscode, and is semi-based on the current grammar in-tree):

F23049936: image.png <https://reviews.llvm.org/F23049936>
F23049986: image.png <https://reviews.llvm.org/F23049986>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125427/new/

https://reviews.llvm.org/D125427



More information about the llvm-commits mailing list