[PATCH] D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen

[Alex Bradbury via Phabricator via llvm-commits]

asb marked an inline comment as done.
asb added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:34-37
+def int_wasm_ref_is_null_extern : Intrinsic<[llvm_i32_ty], [llvm_externref_ty],
+                                            [IntrNoMem], "llvm.wasm.ref.is_null.extern">;
+def int_wasm_ref_is_null_func : Intrinsic<[llvm_i32_ty], [llvm_funcref_ty],
+                                          [IntrNoMem], "llvm.wasm.ref.is_null.func">;
----------------
aheejin wrote:
> Why do we need to specify names explicitly? Aren't these automatically named like these anyway?
The default naming would call these 'llvm.wasm.ref.is.null.foo', and I think aligning to the is_null underlying instruction name is more intuitive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123484/new/

https://reviews.llvm.org/D123484