[PATCH] D125410: [ELF] Align the end of PT_GNU_RELRO to max-page-size instead of common-page-size

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 21:08:26 PDT 2022


MaskRay added a comment.

I somehow forgot that we can not simply round up the end of PT_GNU_RELRO to max-page-size.

I think this is a limitation of our 2 RW PT_LOAD scheme and we may have to expect that if system page size is larger than common-page-size, the last partial page may not be protected by RELRO.
See also https://reviews.freebsd.org/D31498 that system page size smaller than common-page-size may have problems as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125410/new/

https://reviews.llvm.org/D125410



More information about the llvm-commits mailing list