[PATCH] D125457: [InstCombine] [NFC] separate a function foldICmpBinOpWithConstant

[Chenbing.Zheng via Phabricator via llvm-commits]

Chenbing.Zheng marked an inline comment as done.
Chenbing.Zheng added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3337
+    return I;
+}
+
----------------
RKSimon wrote:
> @Chenbing.Zheng Is a return nullptr missing from the end of the function? Or just:
> ```
> // TODO: These folds could be refactored to be part of the above calls.
> return foldICmpBinOpEqualityWithConstant(Cmp, BO, C));
> ```
yer, thanks for your advice. I have fixed it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125457/new/

https://reviews.llvm.org/D125457