[PATCH] D125482: [LLVM][Casting.h] Don't create a temporary while casting.

[Qiongsi Wu via Phabricator via llvm-commits]

qiongsiwu1 added a comment.

In D125482#3510333 <https://reviews.llvm.org/D125482#3510333>, @bzcheeseman wrote:

> In D125482#3510332 <https://reviews.llvm.org/D125482#3510332>, @qiongsiwu1 wrote:
>
>> In D125482#3510328 <https://reviews.llvm.org/D125482#3510328>, @bzcheeseman wrote:
>>
>>> In D125482#3510327 <https://reviews.llvm.org/D125482#3510327>, @qiongsiwu1 wrote:
>>>
>>>> In D125482#3510322 <https://reviews.llvm.org/D125482#3510322>, @bzcheeseman wrote:
>>>>
>>>>> @qiongsiwu1 I assume you ran the whole test suite with no problems? My machine is rather slow so running check-all takes ~many hours for me
>>>>
>>>> Good call - no I did not run the whole test suite. I did run `ninja check-all`. Let me give the test suite a try as well.
>>>
>>> That's what I meant. I think build kite is running `ninja check-clang-tools check-bolt check-mlir check-flang check-all check-lld check-openmp check-clang check-polly check-libc check-llvm`
>>>
>>> build kite is being flaky right now so I'd love a clean bill of health before landing to unblock folks.
>>
>> Ah I see. I tested `check-all`, but I did not build flang/openmp/polly/libc for my local testing. Let me give those a go instead of running the "test-suite".
>
> Many thanks - I assume your build machine is better than mine :)
>
> I got check-clang and check-llvm on my machine and both are all good (which is usually a good sign)

No problem! The ppc buildbot (e.g.  https://lab.llvm.org/buildbot/#/builders/57/builds/17829/steps/6/logs/stdio) is only testing `clang;llvm;clang-tools-extra;lld`, and that was what included in my runs. Those were green!

My local OpenMP tests are having some hiccups but it does not seem to have anything to do with this patch. Bolt is not supported on PPC. `polly`, `mlir` and `flang` checks are green. So I am pretty confident that we are good for Linux on Power. @Jake-Egan can comment more on on AIX but it seems we are good there as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125482/new/

https://reviews.llvm.org/D125482