[PATCH] D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis.

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

can you put the motivation in the description?



================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:104
+static const char *getAnnotatedPassName(Optional<ThinOrFullLTOPhase> LTOPhase) {
+  if ((!AnnotateInlineLTOPhase) || (!LTOPhase.hasValue()))
+    return DEBUG_TYPE;
----------------
these parens aren't necessary


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1134-1135
+                           LTOPhase == ThinOrFullLTOPhase::FullLTOPreLink)
+                              ? true
+                              : false;
   ModulePassManager MPM;
----------------
ternary operator is unnecessary


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125495/new/

https://reviews.llvm.org/D125495