[PATCH] D125491: [RISCV] Add extra space into error message about unsupported extension version.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 12:35:37 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/riscv-arch.c:428
 // RV32-EXPERIMENTAL-BADVERS: error: invalid arch name 'rv32izbt0p1'
 // RV32-EXPERIMENTAL-BADVERS: unsupported version number 0.1 for experimental extension
+// RV32-EXPERIMENTAL-BADVERS: 'zbt' (this compiler supports 0.93)
----------------
Nit: it's better to join `'zbt' (this compiler supports 0.93)` to the previous line since it is one single message.

That's better than using `-SAME:` here, and in turn better than raw CHECK as is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125491/new/

https://reviews.llvm.org/D125491



More information about the llvm-commits mailing list