[PATCH] D125404: [SPIR-V] Add simple transcoding tests

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D125404#3509467 <https://reviews.llvm.org/D125404#3509467>, @andreytr wrote:

> In D125404#3509402 <https://reviews.llvm.org/D125404#3509402>, @MaskRay wrote:
>
>> In D125404#3508754 <https://reviews.llvm.org/D125404#3508754>, @andreytr wrote:
>>
>>> Fixed changes proposed by @MaskRay and @zuban32. I'm not sure about `%[[PTR_ID:[0-9]+]]` etc...
>>> And what about build failures? It seems, these are not related to my patch...
>>
>> You can use the capture pattern `%[[#PTR_ID:]]`, then reference the capture with `%[[#PTR_ID]]`.
>
> Yes, I know. I mean, is it worth to do it? (There may be problems with updating tests from SPIRV-LLVM-Translator's tests repository in future.)

May be not for this case.

That said, I am more concerned with whether a party is willing to clean up tests during an upstreaming process. If not, then the review process in the upstream seems to lose value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125404/new/

https://reviews.llvm.org/D125404