[PATCH] D125478: [llvm-objcopy][test] Add cmp after copy

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 10:30:33 PDT 2022


keith created this revision.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a subscriber: abrachet.
Herald added a project: All.
keith requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

All of the other tests here either check that the copy fails, or that
the resulting binary is the same, it seems like this check was omitted
for the universal object case.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125478

Files:
  llvm/test/tools/llvm-objcopy/MachO/universal-object.test


Index: llvm/test/tools/llvm-objcopy/MachO/universal-object.test
===================================================================
--- llvm/test/tools/llvm-objcopy/MachO/universal-object.test
+++ llvm/test/tools/llvm-objcopy/MachO/universal-object.test
@@ -26,6 +26,7 @@
 ## Case 3: copy an archive containing a universal object.
 # RUN: llvm-ar --format=gnu cr %t.archive.containing.universal %t.universal
 # RUN: llvm-objcopy %t.archive.containing.universal %t.archive.containing.universal.copy
+# RUN: cmp %t.archive.containing.universal %t.archive.containing.universal.copy
 
 ## Case 4: try to copy a universal object file contaning a bitcode slice.
 # RUN: echo 'target triple = "arm64-apple-ios8.0.0"' | llvm-as -o %t.bitcode


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125478.428997.patch
Type: text/x-patch
Size: 734 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220512/60b7400e/attachment.bin>


More information about the llvm-commits mailing list