[PATCH] D125096: [Bazel] Add support for s390x build target

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 10:14:42 PDT 2022


GMNGeoffrey added a comment.

In D125096#3508104 <https://reviews.llvm.org/D125096#3508104>, @vibhutisawant wrote:

> Hi @GMNGeoffrey sorry for the trouble, I uploaded the patch using GUI, and possibly something might have been missed. Will take care next time. Thanks :)

No worries :-) Just a heads up. I don't understand phab well enough to say what the actual issue is, but I think it's a common problem with the web UI that you might end up with a patch with less metadata. One thing you can do that's helpful if still using the web UI is to generate your patches with full context so people can still see the surrounding code. I think in this case you also didn't set the repository field either. Not sure if either of those would've helped with the base revision thing though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125096/new/

https://reviews.llvm.org/D125096



More information about the llvm-commits mailing list