[PATCH] D125413: [ARM64EC 3/?] Mark reserved registers specific to ARM64EC ABI.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:335
+    markSuperRegs(Reserved, AArch64::W28);
+    for (unsigned i = AArch64::B15; i <= AArch64::B31; ++i)
+      markSuperRegs(Reserved, i);
----------------
DavidSpickett wrote:
> efriedma wrote:
> > mstorsjo wrote:
> > > The comment says `v16-v31` but the code seems to go from 15 to 31 - is that a typo? (Based on the comment in the testcase, the code is right and the comment above is the one that is wrong.)
> > Microsoft docs say v16-v31.  Will fix.
> Are you using the "B" name here so that all the various size registers up to "V" get marked as reserved too? (if not you could use "V" to match the comment)
Yes, using the "B" name so markSuperRegs finds all the registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125413/new/

https://reviews.llvm.org/D125413