[PATCH] D125448: [llvm-profgen] Filter out oversized LBR ranges.

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:404
+    auto R = UncondBranchOffsets.upper_bound(Start);
+    return R != UncondBranchOffsets.end() && *R < End;
+  }
----------------
hoy wrote:
> wlei wrote:
> > hoy wrote:
> > > upper_bound seems to find the first element that is greater than Start. How about element equals to Start?
> > So you mean it will immediately jump when ip is on the Start's address, then it should be lower_bound?
> Yeah, lower_bound finds the first element that is not less than Start. It should be fine.
> 
> 
Yeah, that sounds reasonable. The `Start` is actually the LBR's Target,  IMO, the Target should not be an unconditional jmp. I will run on our service to see if we have this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125448/new/

https://reviews.llvm.org/D125448