[PATCH] D125448: [llvm-profgen] Filter out oversized LBR ranges.

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 09:54:11 PDT 2022


wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:404
+    auto R = UncondBranchOffsets.upper_bound(Start);
+    return R != UncondBranchOffsets.end() && *R < End;
+  }
----------------
hoy wrote:
> upper_bound seems to find the first element that is greater than Start. How about element equals to Start?
So you mean it will immediately jump when ip is on the Start's address, then it should be lower_bound?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125448/new/

https://reviews.llvm.org/D125448



More information about the llvm-commits mailing list