[PATCH] D125322: [llvm][json] Fix UINT64 json parsing

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

sounds reasonable to me



================
Comment at: llvm/lib/Support/JSON.cpp:917
 }
-
----------------
what is this?


================
Comment at: llvm/unittests/Support/JSONTest.cpp:388
+
+  // Test with the largest 64 signed int
+  {
----------------
please add a full-stop


================
Comment at: llvm/unittests/Support/JSONTest.cpp:398
+
+  // Test with the largest 64 unsigned int
+  {
----------------
please add a full-stop


================
Comment at: llvm/unittests/Support/JSONTest.cpp:416
+    EXPECT_EQ(Doc->getAsUINT64(), None);
+    // The number was parsed as a double
+    EXPECT_TRUE(!!Doc->getAsNumber());
----------------
please add a full-stop


================
Comment at: llvm/unittests/Support/JSONTest.cpp:428
+    EXPECT_EQ(Doc->getAsUINT64(), None);
+    // The number was parsed as a double
+    EXPECT_TRUE(!!Doc->getAsNumber());
----------------
please add a full-stop


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125322/new/

https://reviews.llvm.org/D125322