[PATCH] D125457: [InstCombine] [NFC] separate a function foldICmpBinOpWithConstant

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 06:09:27 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:3337
+    return I;
+}
+
----------------
@Chenbing.Zheng Is a return nullptr missing from the end of the function? Or just:
```
// TODO: These folds could be refactored to be part of the above calls.
return foldICmpBinOpEqualityWithConstant(Cmp, BO, C));
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125457/new/

https://reviews.llvm.org/D125457



More information about the llvm-commits mailing list