[PATCH] D125319: [AMDGPU] gfx11 BUF Instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 05:52:26 PDT 2022


dp added a comment.

Overall looks fine.

A couple of questions:

- Is dlc a legal modifier for buffer_atomic_* instructions?
- Why there are no tests for buffer_atomic_* with dlc? There should be at least one negative test with dlc if it is not legal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125319/new/

https://reviews.llvm.org/D125319



More information about the llvm-commits mailing list