[PATCH] D125000: [RS4GC] Cache BDVs and bases alogn with IsKnownBase flag (NFC)

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

That looks much safer now! Thanks. LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:442
     // For reasoning see similar case inside 'findBaseDefiningValue' function.
-    return BaseDefiningValueResult(ConstantAggregateZero::get(I->getType()),
-                                   true);
+    auto *CAZ = ConstantAggregateZero::get(I->getType());
+    Cache[I] = CAZ;
----------------
Constants are so trivial that we might not cache them at all. But it's up to you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125000/new/

https://reviews.llvm.org/D125000