[PATCH] D124464: [AArch64] Replace `performANDSCombine` with `performFlagSettingCombine`.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 03:13:53 PDT 2022


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:18852-18853
     return performCSELCombine(N, DCI, DAG);
-  case AArch64ISD::ANDS:
-    return performANDSCombine(N, DCI);
   case AArch64ISD::DUP:
----------------
Kmeakin wrote:
> paulwalker-arm wrote:
> > Is there a good reason to move this code?
> To group it with other calls to `performFlagSettingCombine`
That's not a great reason, especially since it's no longer true.  But it's minor so I'll not worry about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124464/new/

https://reviews.llvm.org/D124464



More information about the llvm-commits mailing list