[PATCH] D125387: Build fix for ValueMap:resize

Pedro Olsen Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 12 01:47:38 PDT 2022


arkangath added a comment.

In D125387#3507490 <https://reviews.llvm.org/D125387#3507490>, @mehdi_amini wrote:

> Does it mean that there are no in-tree user for this API?

This would indicate yes.
I presume no one else (anywhere) uses it either otherwise we'd have been given a build failure bug report.

In D125387#3507490 <https://reviews.llvm.org/D125387#3507490>, @mehdi_amini wrote:

> Are you gonna rename this to  `reserve` as a follow-up patch? I'm not sure I got entirely why not rename it now (that is this API is broken anyway...)?

I intended to have the smallest impact on the patch, and commit as a build fix rather than an API change.
It can be renamed on this patch to reserve() on this patch if that's the preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125387/new/

https://reviews.llvm.org/D125387



More information about the llvm-commits mailing list