[PATCH] D125363: [RISCV] Add an RV64 RUN line to rv32zfhmin-invalid.s
Pretty-box via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 12 01:20:31 PDT 2022
Pretty-box added a comment.
In D125363#3507916 <https://reviews.llvm.org/D125363#3507916>, @sunshaoce wrote:
> LGTM, but I didn't find load/store instructions in other `rv64*-invalid.s`, could you add those either?
This is a good suggestion, I will add these instructions in the next patch.
In D125363#3508212 <https://reviews.llvm.org/D125363#3508212>, @asb wrote:
> Thanks for working to improve our test coverage! In this particular case, I think it would be better handled by adding an RV64 RUN line to rv32zfhmin-invalid.s (given the contents of the file is identical).
done
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125363/new/
https://reviews.llvm.org/D125363
More information about the llvm-commits
mailing list