[PATCH] D125421: [TableGen] Add generation of argument register lists

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/utils/TableGen/CallingConvEmitter.cpp:73
+      CurrentAction = CC->getName().str();
+      (void)AssignedRegsMap[CurrentAction];
       EmitCallingConv(CC, O);
----------------
void wrote:
> nickdesaulniers wrote:
> > What is this code doing? Trying to create a key without an subsequent entry? Suspicious.
> Yes. I want it to have an entry, even if empty, for all actions that we're processing. I'll make the comment clearer.
Can you do something like:

```
AssignedRegsMap[CurrentAction] = {};
```
Instead to insert an empty set?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125421/new/

https://reviews.llvm.org/D125421