[PATCH] D125411: [ARM64EC 1/?] Add parsing support to llvm-objdump/llvm-readobj.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Nice! I started looking into this long ago, but essentially didn't get any further than this patch...

A couple other hunks you might want to incorporate (or maybe you have them queued up already, in later patches - in that case, just disregard me):

  diff --git a/llvm/lib/Object/WindowsMachineFlag.cpp b/llvm/lib/Object/WindowsMachineFlag.cpp
  index f7f2b20ae1a2..eef0ea83c927 100644
  --- a/llvm/lib/Object/WindowsMachineFlag.cpp
  +++ b/llvm/lib/Object/WindowsMachineFlag.cpp
  @@ -25,6 +25,7 @@ COFF::MachineTypes llvm::getMachineType(StringRef S) {
         .Cases("x86", "i386", COFF::IMAGE_FILE_MACHINE_I386)
         .Case("arm", COFF::IMAGE_FILE_MACHINE_ARMNT)
         .Case("arm64", COFF::IMAGE_FILE_MACHINE_ARM64)
  +      .Case("arm64ec", COFF::IMAGE_FILE_MACHINE_ARM64EC)
         .Default(COFF::IMAGE_FILE_MACHINE_UNKNOWN);
   }
   
  @@ -34,6 +35,8 @@ StringRef llvm::machineToStr(COFF::MachineTypes MT) {
       return "arm";
     case COFF::IMAGE_FILE_MACHINE_ARM64:
       return "arm64";
  +  case COFF::IMAGE_FILE_MACHINE_ARM64EC:
  +    return "arm64ec";
     case COFF::IMAGE_FILE_MACHINE_AMD64:
       return "x64";
     case COFF::IMAGE_FILE_MACHINE_I386: 
  diff --git a/llvm/lib/ObjectYAML/COFFEmitter.cpp b/llvm/lib/ObjectYAML/COFFEmitter.cpp
  index d884e2fd55cd..0068ccfe17a6 100644
  --- a/llvm/lib/ObjectYAML/COFFEmitter.cpp
  +++ b/llvm/lib/ObjectYAML/COFFEmitter.cpp
  @@ -48,7 +48,8 @@ struct COFFParser {
     bool isPE() const { return Obj.OptionalHeader.hasValue(); }
     bool is64Bit() const {
       return Obj.Header.Machine == COFF::IMAGE_FILE_MACHINE_AMD64 ||
  -           Obj.Header.Machine == COFF::IMAGE_FILE_MACHINE_ARM64;
  +           Obj.Header.Machine == COFF::IMAGE_FILE_MACHINE_ARM64 ||
  +           Obj.Header.Machine == COFF::IMAGE_FILE_MACHINE_ARM64EC;
     }
   
     uint32_t getFileAlignment() const {


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125411/new/

https://reviews.llvm.org/D125411