[PATCH] D125380: [AMDGPU][GFX10] Support base+soffset+offset SMEM stores.

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 11:59:10 PDT 2022


dp accepted this revision.
dp added a comment.

LGTM

> Looking at how test/MC/AMDGPU/smem.s is organised, it's not perfectly clear to me if we want offset-validation tests for the stores where we already have them for loads.

AFAIK, all features should be covered by lit tests, but there are no specific requirements on test coverage. If it is clear that existing tests cover new functionality, you do not have to add new tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125380/new/

https://reviews.llvm.org/D125380



More information about the llvm-commits mailing list