[PATCH] D125352: [InstCombine] fix sub(add(X,Y),umin(Y,Z)) --> add(X,usub.sat(Y,Z))

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

This shows a shortcoming of the auto-generated check lines. We don't guarantee that we have captured the parameters with the displayed names, so y and z were swapped (miscompile), but it still passed testing. We used to capture parameters directly with the script, so there was no risk of this bug, but that changed somewhere along the line to make the script more flexible. But we can still do that with a script option:
400587ba0c8b1453 <https://reviews.llvm.org/rG400587ba0c8b14537e5b52190ee2fc869f2f9728>

Please update/rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125352/new/

https://reviews.llvm.org/D125352