[PATCH] D125000: [RS4GC] Cache IsKnownBase for bases and BDVs (NFC)

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:694
 
+static bool isKnownBase(Value *V, IsKnownBaseMapTy &KnownBases) {
+  return KnownBases[V];
----------------
const IsKnownBase ... ?


================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:695
+static bool isKnownBase(Value *V, IsKnownBaseMapTy &KnownBases) {
+  return KnownBases[V];
+}
----------------
Pls add assert with descriptive message what happens if the value is missing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125000/new/

https://reviews.llvm.org/D125000