[PATCH] D125276: [TableGen] Remove the use of global Record state

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 21:28:03 PDT 2022


rriddle added inline comments.


================
Comment at: llvm/utils/TableGen/WebAssemblyDisassemblerEmitter.cpp:42
+    auto Opc =
+        static_cast<unsigned>(reinterpret_cast<IntInit *>(
+                                  Inst.convertInitializerTo(IntRecTy::get(RK)))
----------------
craig.topper wrote:
> I know you didn't write, this but can the reinterpret_cast be a cast<>. reinterpret_cast looks suspicious.
Thanks for pointing this out! Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125276/new/

https://reviews.llvm.org/D125276



More information about the llvm-commits mailing list