[PATCH] D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 19:59:22 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGcb22cb2691d0: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC (authored by mingmingl).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125345/new/

https://reviews.llvm.org/D125345

Files:
  llvm/lib/Target/X86/X86InstrInfo.cpp


Index: llvm/lib/Target/X86/X86InstrInfo.cpp
===================================================================
--- llvm/lib/Target/X86/X86InstrInfo.cpp
+++ llvm/lib/Target/X86/X86InstrInfo.cpp
@@ -1049,11 +1049,12 @@
     // in the `AND` and `TEST` operation; signed bit is not known for `AND`,
     // and is known to be 0 as a result of `TEST64rr`.
     //
-    // FIXME: As opposed to poisoning the SF bit direclty, consider peeking into
-    // the AND instruction and using the static information to guide peephole optimization if possible.
-    // For example, it's possible to fold a conditional move into a copy
-    // if the relevant EFLAG bits could be deduced from an immediate operand of and operation.
-    // 
+    // FIXME: As opposed to poisoning the SF bit directly, consider peeking into
+    // the AND instruction and using the static information to guide peephole
+    // optimization if possible. For example, it's possible to fold a
+    // conditional move into a copy if the relevant EFLAG bits could be deduced
+    // from an immediate operand of and operation.
+    //
     NoSignFlag = true;
     // ClearsOverflowFlag is true for AND operation (no surprise).
     ClearsOverflowFlag = true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125345.428555.patch
Type: text/x-patch
Size: 1223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220511/fecf5d10/attachment.bin>


More information about the llvm-commits mailing list