[PATCH] D123481: Do not build with Werror by default (Bazel build)

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 19:10:56 PDT 2022


kuhar added a comment.

In D123481#3505002 <https://reviews.llvm.org/D123481#3505002>, @GMNGeoffrey wrote:

> In D123481#3442718 <https://reviews.llvm.org/D123481#3442718>, @kuhar wrote:
>
>> +1, I had to patch this locally in my project for exactly the reasons you mentioned
>
> I don't understand what you mean about having to patch it locally in a different project. bazelrc files are only applicable to the project itself, not anything that uses it as a dependency.

We build and test llvm before importing because we have a small number of local patches . I don't remember what our issue was exactly, but I think it was something caused by not fully hermetic builds and picking up system headers that caused deprecation warnings in code that used `mallinfo` or something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123481/new/

https://reviews.llvm.org/D123481



More information about the llvm-commits mailing list