[PATCH] D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function.

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.

Two small nitpicks, otherwise LGTM.



================
Comment at: llvm/lib/Target/DirectX/DXILOpLowering.cpp:64
+    return "i64";
+  default:
+    llvm_unreachable("invalid overload type for name");
----------------
Rather than a default case here, fill in all possible enum values (I think you are just missing void, user-defined, and object). Covering all cases will result in a diagnostic if new cases are added and not handled.


================
Comment at: llvm/lib/Target/DirectX/DXILOpLowering.cpp:193
+  std::string FnName = constructOverloadName(Kind, OverloadTy, *Prop);
+  assert(!M.getFunction(FnName) && "Function already exist");
+
----------------
nit: exists


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124805/new/

https://reviews.llvm.org/D124805