[PATCH] D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode

Tue May 10 14:47:34 PDT 2022

nickdesaulniers added a comment.

In D124878#3504577 <https://reviews.llvm.org/D124878#3504577>, @twd2 wrote:

> In D124878#3504573 <https://reviews.llvm.org/D124878#3504573>, @nickdesaulniers wrote:
>
>> In D124878#3504571 <https://reviews.llvm.org/D124878#3504571>, @twd2 wrote:
>>
>>> And, a small question: should we use `SmallSetVector` instead in `SmallPtrSet<Function *, 4> BlockAddressUsers;` to make sure that the order of users encoded in the bitcode is independent of the internal algorithm of `SmallPtrSet`?
>>
>> We don't iterate `BlockAddressUsersVisited`; I think the code is fine as is. Am I missing something?
>
> It's `BlockAddressUsers` in Line 3368, your patch added it.

Ah! Sorry, I mixed up which variable you were referring to. Yeah, looks like it should be. Care to fix that in this patch?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124878/new/

https://reviews.llvm.org/D124878