[PATCH] D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode

Tue May 10 14:01:24 PDT 2022

nickdesaulniers added a comment.

In D124878#3504571 <https://reviews.llvm.org/D124878#3504571>, @twd2 wrote:

> Thank you all for reviewing.

You're welcome. Thanks for the patch!

> Could you please commit this patch on my behalf? Wende Tan <twd2.me at gmail.com>

Sure, I can take care of that.

> And, a small question: should we use `SmallSetVector` instead in `SmallPtrSet<Function *, 4> BlockAddressUsers;` to make sure that the order of users encoded in the bitcode is independent of the internal algorithm of `SmallPtrSet`?

We don't iterate `BlockAddressUsersVisited`; I think the code is fine as is. Am I missing something?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124878/new/

https://reviews.llvm.org/D124878