[PATCH] D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 10:58:16 PDT 2022


hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.

LGTM with a minor suggestion.



================
Comment at: llvm/tools/llvm-profgen/ErrorHandling.h:53
+inline void emitWarningSummary(uint64_t Num, uint64_t Total, StringRef Msg,
+                               bool IsCritical = false) {
+  if (Total && Num && (VerboseMode || IsCritical))
----------------
nit: IsCritical -> AlwaysEmit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125255/new/

https://reviews.llvm.org/D125255



More information about the llvm-commits mailing list